Add AddToFrameworkScheme function for the test framework #393
+288
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexNPavel
force-pushed
the
test-scheme
branch
from
8e41c69
to
7352f48
Compare
AlexNPavel
force-pushed
the
test-scheme
branch
from
f288683
to
851e600
Compare
|
I just removed all the functions that are now unnecessary due to the dynamic client. |
|
LGTM |
fanminshi
reviewed
Aug 13, 2018
| "testing" | ||
| "time" | ||
|
|
||
| operator "github.com/operator-framework/operator-sdk/test/test-framework/pkg/apis/cache/v1alpha1" | ||
|
|
There was a problem hiding this comment.
group all "github.com/operator-framework/operator-sdk/* together. So no new line here.
| framework "github.com/operator-framework/operator-sdk/pkg/test" | ||
| "github.com/operator-framework/operator-sdk/pkg/util/e2eutil" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
There was a problem hiding this comment.
new line between line 26 and 27
|
lgtm after nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function that allows user to register their custom resources with the test framework's dynamic client and use the dynamic client directly with their custom resources.
Part of issue #387.